[HOTFIX] Validate note name #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
reviewed
Jul 10, 2023
zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java
Outdated
Show resolved
Hide resolved
Reamer
requested changes
Jul 10, 2023
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
Outdated
Show resolved
Hide resolved
…bookServiceTest.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
…bookService.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
Reamer
previously approved these changes
Jul 10, 2023
huage1994
approved these changes
Jul 18, 2023
akoira
pushed a commit
to akoira/zeppelin
that referenced
this pull request
Feb 1, 2024
* [HOTFIX] Validate note name * [HOTFIX] Validate note name * [HOTFIX] Validate note name * Update zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com> * Update zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com> * [HOTFIX] Fix commented --------- Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
dmetasoul01
pushed a commit
to meta-soul/zeppelin
that referenced
this pull request
May 14, 2024
* [HOTFIX] Validate note name * [HOTFIX] Validate note name * [HOTFIX] Validate note name * Update zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com> * Update zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com> * [HOTFIX] Fix commented --------- Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Checking invalid note name like './';
What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: