chore: bump phpstan version #7239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
bumpPhpstan
branch
from
12d82b6 to
739f51c
Compare
VincentLanglet
commented
Jun 20, 2025
| @@ -17,7 +17,6 @@ parameters: | |||
| excludePaths: | |||
| # uses larastan | |||
| - src/Laravel | |||
| - src/Symfony/Bundle/Command/OpenApiCommand.php | |||
There was a problem hiding this comment.
Those files doesn't exists and are reported by PHPStan v2 now.
| @@ -75,6 +71,15 @@ parameters: | |||
| # Expected, due to backward compatibility | |||
| - '#Method GraphQL\\Type\\Definition\\WrappingType::getWrappedType\(\) invoked with 1 parameter, 0 required\.#' | |||
| - '#Access to an undefined property GraphQL\\Type\\Definition\\NamedType&GraphQL\\Type\\Definition\\Type::\$name\.#' | |||
| - "#Call to function method_exists\\(\\) with GraphQL\\\\Type\\\\Definition\\\\Type&GraphQL\\\\Type\\\\Definition\\\\WrappingType and 'getInnermostType' will always evaluate to true\\.#" | |||
There was a problem hiding this comment.
There is a lot of method_exists call added for BC, so I updated the ignored errors.
| # Allow extra assertions in tests: https://github.com/phpstan/phpstan-strict-rules/issues/130 | ||
| - '#^Call to (static )?method PHPUnit\\Framework\\Assert::.* will always evaluate to true\.$#' | ||
|
|
||
| # TODO For PHPStan 2.0 |
There was a problem hiding this comment.
This is a list of errors which I'd like to fix in following PR.
| @@ -56,10 +56,6 @@ public function provide(Operation $operation, array $uriVariables = [], array $c | |||
| $manager = $this->managerRegistry->getManagerForClass($entityClass); | |||
|
|
|||
| $repository = $manager->getRepository($entityClass); | |||
| if (!method_exists($repository, 'createQueryBuilder')) { | |||
There was a problem hiding this comment.
$repository is always an EntityRepository according to PHPStan and I think it's right.
| @@ -65,10 +65,6 @@ public function provide(Operation $operation, array $uriVariables = [], array $c | |||
| } | |||
|
|
|||
| $repository = $manager->getRepository($entityClass); | |||
| if (!method_exists($repository, 'createQueryBuilder')) { | |||
| @@ -41,6 +41,7 @@ public function testParameterFactory(): void | |||
| $filterLocator->method('get')->willReturn(new class implements FilterInterface { | |||
| public function getDescription(string $resourceClass): array | |||
| { | |||
| // @phpstan-ignore-next-line return.type | |||
There was a problem hiding this comment.
Seems like we're passing volontary a wrong type to check it's handle in the method.
| @@ -101,7 +101,7 @@ public function normalize(mixed $object, ?string $format = null, array $context | |||
| */ | |||
| protected function normalizeRawCollection(iterable $object, ?string $format = null, array $context = []): array|\ArrayObject | |||
| { | |||
| if (!$object && ($context[Serializer::EMPTY_ARRAY_AS_OBJECT] ?? false) && \is_array($object)) { | |||
| if ([] === $object && ($context[Serializer::EMPTY_ARRAY_AS_OBJECT] ?? false)) { | |||
There was a problem hiding this comment.
!$object already enforce it's [].
But I rewrote the condition to be explicit
| @@ -1163,9 +1163,10 @@ private function createAndValidateAttributeValue(string $attribute, mixed $value | |||
| } | |||
|
|
|||
| if ( | |||
| ($t instanceof CollectionType && $collectionValueType instanceof ObjectType && (null !== ($className = $collectionValueType->getClassName()))) | |||
| || ($t instanceof LegacyType && $t->isCollection() && null !== $collectionValueType && null !== ($className = $collectionValueType->getClassName())) | |||
| ($t instanceof CollectionType && $collectionValueType instanceof ObjectType) | |||
There was a problem hiding this comment.
In this condition (null !== ($className = $collectionValueType->getClassName())) is always true cause getClassName returns a string.
So we need to remove it from the condition, and it force declaring the variable after the if.
| @@ -91,9 +91,6 @@ private function normalizeJson(mixed $document): object|array | |||
| } | |||
|
|
|||
| $document = json_encode($document, \JSON_THROW_ON_ERROR); | |||
| if (!\is_string($document)) { | |||
There was a problem hiding this comment.
$document is always a string because of JSON_THROW_ON_ERROR
| @@ -47,7 +47,6 @@ public static function getResources(): array | |||
| public function testRequest(): void | |||
| { | |||
| $client = self::createClient(); | |||
| $client->getKernelBrowser(); | |||
There was a problem hiding this comment.
Useless call
VincentLanglet
force-pushed
the
bumpPhpstan
branch
2 times, most recently
from
1f70618 to
299f4cb
Compare
VincentLanglet
force-pushed
the
bumpPhpstan
branch
from
299f4cb to
6837010
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @soyuka,
I wanted to bump PHPStan level to 6 and saw it was still using v1 ; so I started by bumping to v2.
Since there is lot of new errors I used the following strategy
Then I'll provide PR to fix some identifiers error, but I think it's better to split PR for readability.