Update serialization.md #1490
Open
Update serialization.md #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add enable_max_depth details
dunglas
requested changes
Dec 28, 2021
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
vincentchalamon
requested changes
Jul 20, 2022
vincentchalamon
approved these changes
Aug 19, 2022
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
vincentchalamon
requested changes
Jan 14, 2025
| use Symfony\Component\Serializer\Annotation\MaxDepth; | ||
|
|
||
| #[ApiResource( | ||
| normalizationContext: ['groups' => 'read', 'enable_max_depth' => true], |
There was a problem hiding this comment.
Suggested change
| normalizationContext: ['groups' => 'read', 'enable_max_depth' => true], | |
| normalizationContext: ['groups' => ['read'], 'enable_max_depth' => true], |
| #[Groups(["read", "write"])] | ||
| public $name; | ||
|
|
||
| #[Groups("write")] |
There was a problem hiding this comment.
Suggested change
| #[Groups("write")] | |
| #[Groups(["write"])] |
Comment on lines
+52
to
+54
| use ApiPlatform\Core\Annotation\ApiResource; | ||
| use Symfony\Component\Serializer\Annotation\Groups; | ||
| use Symfony\Component\Serializer\Annotation\MaxDepth; |
There was a problem hiding this comment.
I would recommend to target 4.0 branch instead of 3.4, and update the imports as following:
Suggested change
| use ApiPlatform\Core\Annotation\ApiResource; | |
| use Symfony\Component\Serializer\Annotation\Groups; | |
| use Symfony\Component\Serializer\Annotation\MaxDepth; | |
| use ApiPlatform\Metadata\ApiResource; | |
| use Symfony\Component\Serializer\Attribute\Groups; | |
| use Symfony\Component\Serializer\Attribute\MaxDepth; |
|
I would suggest to target 4.0 branch instead of 3.4, WDYT @vinceAmstoutz @soyuka? |
IMHO |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few details about max_depth and enable_max_depth