Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): upstream health checker optional field schema #169

Merged
merged 6 commits into from
Aug 9, 2024
Merged

fix(core): upstream health checker optional field schema #169

merged 6 commits into from
Aug 9, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Aug 9, 2024

Description

According to the APISIX schema, the host and port of the active health checker are optional.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 marked this pull request as ready for review August 9, 2024 12:56
@bzp2010 bzp2010 changed the title fix: upstream health checker optional field schema fix(core): upstream health checker optional field schema Aug 9, 2024
@bzp2010 bzp2010 merged commit 6751020 into main Aug 9, 2024
6 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-upstream-healthchecker-optional-field branch August 9, 2024 13:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@pottekkat pottekkat Awaiting requested review from pottekkat

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzp2010 @juzhiyuan