Skip to content

feat: add ImpitHttpClient http-client client using the impit library #1151

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Mantisus
Copy link
Collaborator

Description

  • add ImpitHttpClient http-client client using the impit library

Issues

Testing

Added tests for ImpitHttpClient. ImpitHttpClient is enabled for all tests using http-client

@Mantisus
Copy link
Collaborator Author

For now, I suggest adding impit as an additional dependency, as it still needs some tweaking before it's ready to replace httpx.

Awaiting a decision - apify/impit#123

@Mantisus Mantisus requested a review from Copilot April 14, 2025 15:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

pyproject.toml:63

  • The version requirement for impit in the main dependencies (>=0.1.0) differs from the one in the adaptive-crawler section (>=0.2.0), which may lead to dependency conflicts. Consider aligning them to a consistent version.
"impit>=0.1.0",

@Mantisus Mantisus requested a review from Copilot April 14, 2025 15:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

@Mantisus Mantisus self-assigned this Apr 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant