test building all images with version tag

apo-ger · Dec 16, 2022 · ae790bc · ae790bc
1 parent 589765d
commit ae790bc
Show file tree

Hide file tree

Showing 17 changed files with 119 additions and 243 deletions.
diff --git a/.github/workflows/centraldb_angular_docker_publish.yaml b/.github/workflows/centraldb_angular_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish CentralDashboard-Angular Docker image
+name: Build CentralDashboard-Angular Docker image
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -11,11 +11,11 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/centraldashboard-angular
-  TAG: latest
+  TAG: top-level-latest
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -30,26 +30,13 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Run CentralDashboard-Angular build
       run: |
         cd components/centraldashboard-angular
         make docker-build
 
-    - name: Run CentralDashboard-Angular push
+    - name: Run CentralDashboard build on version tag
       run: |
+        export TAG=$(cat releasing/version/VERSION)
         cd components/centraldashboard-angular
-        make docker-push
-
-    - name: Run CentralDashboard-Angular push on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
-      run: |
-        export VERSION_TAG=$(cat releasing/version/VERSION)
-        docker tag ${{env.IMG}}:${{env.TAG}} ${{env.IMG}}:${VERSION_TAG}
-        docker push ${{env.IMG}}:${VERSION_TAG}
+        make docker-build
diff --git a/.github/workflows/centraldb_docker_publish.yaml b/.github/workflows/centraldb_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish CentralDashboard Docker image
+name: Build CentralDashboard Docker image
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -11,11 +11,11 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/centraldashboard
-  TAG: latest
+  TAG: top-level-latest
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -30,28 +30,15 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Run CentralDashboard build
       run: |
         cd components/centraldashboard
         make docker-build
-
-    - name: Run CentralDashboard push
+    
+    - name: Run CentralDashboard build on version tag
       run: |
+        export TAG=$(cat releasing/version/VERSION)
         cd components/centraldashboard
-        make docker-push
-
-    - name: Run CentralDashboard push on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
-      run: |
-        export VERSION_TAG=$(cat releasing/version/VERSION)
-        docker tag ${{env.IMG}}:${TAG} ${{env.IMG}}:${VERSION_TAG}
-        docker push ${{env.IMG}}:${VERSION_TAG}
+        make docker-build
 
       
diff --git a/.github/workflows/jwa_docker_publish.yaml b/.github/workflows/jwa_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish JWA Docker image
+name: Build JWA Docker image
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -13,11 +13,11 @@ env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/jupyter-web-app
   ARCH: linux/ppc64le,linux/amd64
-  TAG: latest
+  TAG: top-level-latest
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -32,27 +32,19 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Setup QEMU
       uses: docker/setup-qemu-action@v2
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-    - name: Build and push multi-arch docker image
+    - name: Build multi-arch docker image
       run: |
         cd components/crud-web-apps/jupyter
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
 
-    - name: Build and push multi-arch docker image on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
+    - name: Build multi-arch docker image on Version change
       run: |
         export TAG=$(cat releasing/version/VERSION)
         cd components/crud-web-apps/jupyter
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
diff --git a/.github/workflows/kfam_docker_publish.yaml b/.github/workflows/kfam_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish KFAM Docker image
+name: Build KFAM Docker image
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -12,11 +12,11 @@ env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/kfam
   ARCH: linux/ppc64le,linux/amd64
-  TAG: latest
+  TAG: top-level-latest
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -31,27 +31,19 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Setup QEMU
       uses: docker/setup-qemu-action@v2
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-    - name: Build and push multi-arch docker image
+    - name: Build multi-arch docker image
       run: |
         cd components/access-management
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
 
-    - name: Build and push multi-arch docker image on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
+    - name: Build multi-arch docker image on Version change
       run: |
         export TAG=$(cat releasing/version/VERSION)
         cd components/access-management
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
diff --git a/.github/workflows/nb_controller_docker_publish.yaml b/.github/workflows/nb_controller_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish Notebook Controller Docker image
+name: Build Notebook Controller Docker image
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -13,11 +13,11 @@ env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/notebook-controller
   ARCH: linux/ppc64le,linux/amd64
-  TAG: latest
+  TAG: top-level-latest
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -32,12 +32,6 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Setup QEMU
       uses: docker/setup-qemu-action@v2
       with:
@@ -46,15 +40,13 @@ jobs:
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-    - name: Build and push multi-arch docker image
+    - name: Build multi-arch docker image
       run: |
         cd components/notebook-controller
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
 
-    - name: Build and push multi-arch docker image on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
+    - name: Build multi-arch docker image on Version change
       run: |
         export TAG=$(cat releasing/version/VERSION)
         cd components/notebook-controller
-        make docker-build-push-multi-arch
+        make docker-build-multi-arch
diff --git a/.github/workflows/nb_server_codeserver_python_docker_publish.yaml b/.github/workflows/nb_server_codeserver_python_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish Codeserver Python Notebook Server Docker images
+name: Build Codeserver Python Notebook Server Docker images
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -11,13 +11,13 @@ on:
       - releasing/version/VERSION
 
 env:
-  TAG: latest
+  TAG: top-level-latest
   DOCKER_USER: kubeflownotebookswg
   REGISTRY: kubeflownotebookswg
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build & TAG Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -32,26 +32,27 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER}}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
+    - name: Install KinD
+      run: ./components/testing/gh-actions/install_kind.sh
+
+    - name: Create KinD Cluster
+      run: kind create cluster --config components/testing/gh-actions/kind-1-25.yaml
 
     - name: Build Notebook Server images via their Makefile
       run: |
         cd components/example-notebook-servers/
         make docker-build -C codeserver-python TAG=${{env.TAG}}
     
-    - name: Push Notebook Server images
+    - name: TAG Notebook Server images
       run: |
         docker tag codeserver-python:${{env.TAG}} ${{env.REGISTRY}}/codeserver-python:${{env.TAG}}
-        docker push ${{env.REGISTRY}}/codeserver-python:${{env.TAG}}
+        kind load docker-image ${{env.REGISTRY}}/codeserver-python:${{env.TAG}}
 
-    - name: Push Notebook Server images on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
+    - name: TAG Notebook Server images on Version change
       run: |
         export VERSION_TAG=$(cat releasing/version/VERSION)
+        echo ${VERSION_TAG}
         docker tag codeserver-python:${{env.TAG}} ${{env.REGISTRY}}/codeserver-python:${VERSION_TAG}
-        docker push ${{env.REGISTRY}}/codeserver-python:${VERSION_TAG}
+        kind load docker-image ${{env.REGISTRY}}/codeserver-python:${VERSION_TAG}
+        docker images
+
diff --git a/.github/workflows/nb_server_jupyter_pytorch_full_docker_publish.yaml b/.github/workflows/nb_server_jupyter_pytorch_full_docker_publish.yaml
@@ -1,6 +1,6 @@
-name: Build & Publish Jupyter Pytorch Full Notebook Server Docker images
+name: Build Jupyter Pytorch Full Notebook Server Docker images
 on:
-  push:
+  pull_request:
     branches:
       - master
       - v*-branch
@@ -12,13 +12,13 @@ on:
       - releasing/version/VERSION
 
 env:
-  TAG: latest
+  TAG: top-level-latest
   DOCKER_USER: kubeflownotebookswg
   REGISTRY: kubeflownotebookswg
 
 jobs:
   push_to_registry:
-    name: Build & Push Docker image to Docker Hub
+    name: Build Docker image to Docker Hub
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -33,12 +33,6 @@ jobs:
           version:
             - 'releasing/version/VERSION'
 
-    - name: Login to DockerHub
-      uses: docker/#-action@v2
-      with:
-        username: ${{ env.DOCKER_USER }}
-        password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-
     - name: Build Notebook Server images via their Makefile
       run: |
         cd components/example-notebook-servers/
@@ -48,16 +42,12 @@ jobs:
     - name: Push Notebook Server images
       run: |
         docker tag jupyter-pytorch-full:${{env.TAG}} ${{env.REGISTRY}}/jupyter-pytorch-full:${{env.TAG}}
-        docker push ${{env.REGISTRY}}/jupyter-pytorch-full:${{env.TAG}}
         docker tag jupyter-pytorch-cuda-full:${{env.TAG}} ${{env.REGISTRY}}/jupyter-pytorch-cuda-full:${{env.TAG}}
-        docker push ${{env.REGISTRY}}/jupyter-pytorch-cuda-full:${{env.TAG}}
 
     - name: Push Notebook Server images on Version change
-      id: version
-      if: steps.filter.outputs.version == 'true'
       run: |
         export VERSION_TAG=$(cat releasing/version/VERSION)
+        echo ${VERSION_TAG}
         docker tag jupyter-pytorch-full:${{env.TAG}} ${{env.REGISTRY}}/jupyter-pytorch-full:${VERSION_TAG}
-        docker push ${{env.REGISTRY}}/jupyter-pytorch-full:${VERSION_TAG}
         docker tag jupyter-pytorch-cuda-full:${{env.TAG}} ${{env.REGISTRY}}/jupyter-pytorch-cuda-full:${VERSION_TAG}
-        docker push ${{env.REGISTRY}}/jupyter-pytorch-cuda-full:${VERSION_TAG}
+