Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

run tests with next 15, bump peerDependency #379

Merged
merged 3 commits into from
Oct 22, 2024
Merged

run tests with next 15, bump peerDependency #379

merged 3 commits into from
Oct 22, 2024

Conversation

phryneas
Copy link
Member

No description provided.

@phryneas phryneas requested a review from a team as a code owner October 22, 2024 08:58
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for apollo-client-nextjs-docmodel ready!

Name Link
🔨 Latest commit 5f77ad4
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-nextjs-docmodel/deploys/67177424fe97a5000883e479
😎 Deploy Preview https://deploy-preview-379--apollo-client-nextjs-docmodel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 22, 2024

yarn@berry undefined https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-react-streaming@379
yarn@berry undefined https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/experimental-nextjs-app-support@379

commit: 5f77ad4

Copy link

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size
{ ApolloNextAppProvider, ApolloClient, InMemoryCache } from '@apollo/experimental-nextjs-app-support' (Browser ESM) 7.36 KB (+49.31% 🔺)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.8 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 3 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.51 KB (0%)
@apollo/client-react-streaming (SSR ESM) 7.34 KB (0%)
@apollo/client-react-streaming (RSC ESM) 7.18 KB (0%)
@apollo/client-react-streaming/manual-transport (Browser ESM) 3.21 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 8.3 KB (0%)
@apollo/experimental-nextjs-app-support (Browser ESM) 7.95 KB (+44.05% 🔺)
@apollo/experimental-nextjs-app-support (SSR ESM) 13.05 KB (+22.19% 🔺)
@apollo/experimental-nextjs-app-support (RSC ESM) 7.23 KB (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 6.38 KB (0%)

@The-Code-Monkey
Copy link

@phryneas thank you for this, just made a PR myself and realised you had beat me to it by 1 minute

@phryneas
Copy link
Member Author

@The-Code-Monkey Thank you for opening that other PR!

I'll probably have to tweak a few more things, so I hope it's okay if we leave things to this PR for now, okay? :)

@The-Code-Monkey
Copy link

@phryneas yeah thats fine, hopefully this is pretty straight forwards though and not much needs changing. I use the nextjs experimental package at work so would be nice to be able to update as soon as. but not a big rush.

@phryneas
Copy link
Member Author

Seems that at least some things in our tests need to change due to breaking Next.js changes.

@The-Code-Monkey
Copy link

Ah yeah headers, cookies, params are now all async. that will probably be the biggest change.

@phryneas
Copy link
Member Author

I wish it were
https://x.com/phry/status/1848658202805641322

@The-Code-Monkey
Copy link

Oh fun. well it was going to break some packages. strange that it went from error to undefined though

@phryneas
Copy link
Member Author

I mean, it's only in our tests where we test that React should throw a certain error in a specific situation, so I'll shrug it off as RC weirdness, but it doesn't give me a whole lot of confidence into Next 15 so far.

Copy link

relativeci bot commented Oct 22, 2024

#267 Bundle Size — 1.2MiB (+8.77%).

5f77ad4(current) vs 4834f55 main#265(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  Change 7 changes Regression 2 regressions
                 Current
#267
     Baseline
#265
Regression  Initial JS 967.91KiB(+4.72%) 924.27KiB
No change  Initial CSS 70B 70B
Change  Cache Invalidation 99.89% 22.66%
Change  Chunks 34(+3.03%) 33
Change  Assets 59(+3.51%) 57
Change  Modules 630(+7.14%) 588
Regression  Duplicate Modules 106(+7.07%) 99
Change  Duplicate Code 5.33%(-14.45%) 6.23%
No change  Packages 26 26
No change  Duplicate Packages 1 1
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#267
     Baseline
#265
Regression  JS 1.19MiB (+8.81%) 1.09MiB
Regression  Other 9.09KiB (+3.56%) 8.78KiB
No change  CSS 70B 70B

Bundle analysis reportBranch pr/next-15Project dashboard


Generated by RelativeCIDocumentationReport issue

@phryneas
Copy link
Member Author

Well, that's now all green. I'll take the win and get this released :)

@phryneas phryneas merged commit cc77fe1 into main Oct 22, 2024
25 checks passed
@phryneas phryneas deleted the pr/next-15 branch October 22, 2024 09:54
@phryneas
Copy link
Member Author

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants