-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: extract watchFragment into separate method on ApolloCache #11465
Conversation
🦋 Changeset detectedLatest commit: 46c8eb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
f23c7e1
to
f122e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so stoked about this one! I think this will lay some great groundwork for the fragment features we want to release in 3.10 as well as providing this API to non-React devs. Thanks for starting this!
Left some initial feedback based on its current state 🙂
Thanks for the speedy review, @jerelmiller! Will make these changes and push up some more tests shortly :) |
fe7bb96
to
67c1e1c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/release:pr |
A new release has been made for this PR. You can install it with |
13fa56e
to
07568d1
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…graphql/apollo-client into issue-11348-extract-watchFragment
…graphql/apollo-client into issue-11348-extract-watchFragment
Not sure why Netlify build is failing with "Error: error:0308010C:digital envelope routines::unsupported", will take a look in a bit. |
/release:pr |
A new release has been made for this PR. You can install it with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So excited to get this in! Thanks for pushing this along 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This looks great! Really looking forward to getting this out there 🙂
Closes #11348.
Initial refactor of
useFragment
's call tocache.watch
into separatewatchFragment
method on the cache.