-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adjust useReadQuery wrapper logic to work with transported objects. #11757
Conversation
🦋 Changeset detectedLatest commit: 216398d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
A new release has been made for this PR. You can install it with:
|
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me! This is such an exciting feature 🎉
Prerequisite for apollographql/apollo-client-nextjs#258.
Because in that situation,
useReadQuery
is not called with a realqueryRef
, but with some serializable "transport object", the existing logic crashed when trying to accessundefined["observable"]
(sincetransportObject[QUERY_REFERENCE_SYMBOL]
would beundefined
, as symbol properties cannot be (de)serialized)