-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: rename createProxiedSchema
to createTestSchema
#11764
Conversation
🦋 Changeset detectedLatest commit: 837286b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full agree! Rolls off the tongue much nicer. Thank you!
.api-reports/api-report-testing.md
Outdated
@@ -465,7 +465,7 @@ export const createMockSchema: (staticSchema: GraphQLSchema, mocks: { | |||
// Warning: (ae-forgotten-export) The symbol "ProxiedSchema" needs to be exported by the entry point index.d.ts | |||
// | |||
// @alpha | |||
export const createProxiedSchema: (schemaWithMocks: GraphQLSchema, resolvers: Resolvers) => ProxiedSchema; | |||
export const createSchemaProxy: (schemaWithMocks: GraphQLSchema, resolvers: Resolvers) => ProxiedSchema; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createTestSchema{Wrapper}
?
createProxiedSchema
to createSchemaProxy
createProxiedSchema
to createTestSchema
…h to createSchemaFetch
The more I typed out
createProxiedSchema
, the more inverting the two important nouns in the name made sense to me :) that and "proxied" feels a bit awkward to type. Maybe just me, would love any feedback here!