Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use keyDirective() for entity detection #3188

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Use keyDirective() for entity detection #3188

merged 1 commit into from
Nov 27, 2024

Conversation

clenfest
Copy link
Contributor

For entity detection, make sure we're using the keyDirective as it appears in the subgraph schema

fixes #3187

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 27, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/federation@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "federation",
        "branch": "clenfest/3187"
      }
    }
  }
}
Name Link

Commit

1f04295

Preview

https://www.apollographql.com/docs/deploy-preview/d5934e3c4e9590875b0d

Build ID

d5934e3c4e9590875b0d

File Changes

0 new, 12 changed, 0 removed
* graphos/reference/router/telemetry/instrumentation/standard-instruments.mdx
* graphos/reference/router/rhai.mdx
* graphos/reference/router/errors.mdx
* graphos/reference/router/configuration.mdx
* graphos/routing/customization/coprocessor.mdx
* graphos/routing/customization/overview.mdx
* graphos/routing/observability/subgraph-error-inclusion.mdx
* graphos/routing/observability/client-id-enforcement.mdx
* graphos/routing/performance/caching/entity.mdx
* graphos/routing/security/authorization.mdx
* graphos/routing/security/request-limits.mdx
* graphos/routing/self-hosted/containerization/index.mdx

Pages

12


12 pages published. Build will be available for 30 days.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 1f04295

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest marked this pull request as ready for review November 27, 2024 17:11
@clenfest clenfest requested a review from a team as a code owner November 27, 2024 17:11
@clenfest clenfest merged commit 78868dd into main Nov 27, 2024
16 checks passed
@clenfest clenfest deleted the clenfest/3187 branch November 27, 2024 20:02
clenfest added a commit that referenced this pull request Dec 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive on INCONSISTENT_OBJECT_VALUE_TYPE_FIELD when using @federation__key
3 participants