Subscriptions: Correct v1.28.x regression allowing panic via un-named subscription operation #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the contexts OPERATION_NAME to be set to None.
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
BrynCooke
approved these changes
Sep 4, 2023
…ographql/router into igni/anonymous_operation_name_test
Geal
reviewed
Sep 4, 2023
| let operation_name = request | ||
| .subgraph_request | ||
| .body() | ||
| .operation_name |
There was a problem hiding this comment.
is that really the expected behaviour here? The operation name that was set in the subgraph request is defined by query planner, so it will be different from the operation name extracted in query analysis
There was a problem hiding this comment.
oh I see, that was introduced in ed6a9fb#diff-6ef5a208ca8622f30eef88f75c18566e0304d59856b66293dcd6811555e6382e
o0Ignition0o
changed the title
Geal
approved these changes
Sep 4, 2023
abernix
pushed a commit
that referenced
this pull request
Sep 4, 2023
… subscription operation (#3738) ### Subscriptions: Correct v1.28.x regression allowing panic via un-named subscription operation Correct a regression that was introduced in Router v1.28.0 which made a Router **panic** possible when the following _three_ conditions are _all_ met: 1. When sending an un-named (i.e., "anonymous") `subscription` operation (e.g., `subscription { ... }`); **and**; 2. The Router has a `subscription` type defined in the Supergraph schema; **and** 3. Have subscriptions enabled (they are disabled by default) in the Router's YAML configuration, either by setting `enabled: true` _or_ by setting a `mode` within the `subscriptions` object (as seen in [the subscriptions documentation]
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the contexts OPERATION_NAME to be set to None.