Restructure and add logging to failing E2E test #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_run_rover_supergraph_compose` has been failing for a while now and its not clear why. This restructures the test and adds more logging so we can easily diagnose why this happens.
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b90dd9d74a664a3851799a31 |
nmoutschen
approved these changes
Feb 17, 2025
Merged
jonathanrainer
added a commit
that referenced
this pull request
Feb 19, 2025
## 🐛 Fixes - **Restore the ability to use environment or file references in the `supergraph.yaml` file - @jonathanrainer PR #2411** In v0.26.3 and older you could use references such as `${env.HOST}` or similar in the `supergraph.yaml` file, there was an oversight in the refactor and this was removed. This ability has now been restored. ## 🛠 Maintenance - **Restructure and add logging to failing E2E test - @jonathanrainer PR #2406** - **Upgrade Rust to v1.84.0 - @jonathanrainer PR #2407** - **Upgrade `apollographql/federation-rs` to v2.10.0 - @jonathanrainer PR #2409** - **Upgrade `thiserror` to v2.0.1 - @jonathanrainer PR #2261**
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_run_rover_supergraph_composehas been failing for a while now and its not clear why. This restructures thetest and adds more logging so we can easily diagnose why this happens.