Replace prettytable-rs with comfy-table

[pubmodmatt]

Replace the prettytable-rs dependency with comfy-table.

Motivation

The table output by rover config whoami was misalgined, due to this issue in prettytable-rs:

┌───────────────┬────────────────────────────────────────────┐
│ Key Type    │ Graph                                      │
├───────────────┼────────────────────────────────────────────┤
│ Graph ID    │ SpaceOrbit3                                │
├───────────────┼────────────────────────────────────────────┤
│ Graph Title │ SpaceOrbit                                 │
├───────────────┼────────────────────────────────────────────┤
│ Origin      │ $APOLLO_KEY                                │
├───────────────┼────────────────────────────────────────────┤
│ API Key     │ ****************************************** │
└───────────────┴────────────────────────────────────────────┘

As pointed out in the comparison with other libraries in the comfy-table docs, it appears that prettytable-rs may be abandoned. The fix for the above issue has had an open PR for several months, but it has not been merged and released. comfy-table appears to be actively developed, and had a new version release 12 days ago.

Differences

Dropping in comfy-table is almost seamless. There are a few very slight differences in the output, in addition to fixing the above alignment issue:

• The bold headers were not working with prettytable-rs, but they do work with comfy-table
• comfy-table uses a double line between the header row and the next row, more clearly delineating the headers
• The comfy-table preset uses dashed lines inside the table, and solid lines for the table border, provding a nice visual separation. prettytable-rs used solid lines everywhere.

Comparison

Note that the examples below do not show bold fonts or colors that would appear in the terminal.

rover config whoami

prettytable-rs

┌───────────────┬────────────────────────────────────────────┐
│ Key Type    │ Graph                                      │
├───────────────┼────────────────────────────────────────────┤
│ Graph ID    │ SpaceOrbit3                                │
├───────────────┼────────────────────────────────────────────┤
│ Graph Title │ SpaceOrbit                                 │
├───────────────┼────────────────────────────────────────────┤
│ Origin      │ $APOLLO_KEY                                │
├───────────────┼────────────────────────────────────────────┤
│ API Key     │ ****************************************** │
└───────────────┴────────────────────────────────────────────┘

comfy-table

┌─────────────┬────────────────────────────────────────────┐
│ Key Type    ┆ Graph                                      │
├╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Graph ID    ┆ SpaceOrbit3                                │
├╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Graph Title ┆ SpaceOrbit                                 │
├╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Origin      ┆ $APOLLO_KEY                                │
├╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ API Key     ┆ ****************************************** │
└─────────────┴────────────────────────────────────────────┘

rover docs list

prettytable-rs

┌──────────────┬──────────────────────────────────────┐
│     Slug     │             Description              │
├──────────────┼──────────────────────────────────────┤
│ api-keys     │ Understanding Apollo's API Keys      │
├──────────────┼──────────────────────────────────────┤
│ contributing │ Contributing to Rover                │
├──────────────┼──────────────────────────────────────┤
│ docs         │ Rover's Documentation Homepage       │
├──────────────┼──────────────────────────────────────┤
│ migration    │ Migrate from the Apollo CLI to Rover │
├──────────────┼──────────────────────────────────────┤
│ start        │ Getting Started with Rover           │
└──────────────┴──────────────────────────────────────┘

comfy-table

┌──────────────┬──────────────────────────────────────┐
│     Slug     ┆              Description             │
╞══════════════╪══════════════════════════════════════╡
│ api-keys     ┆ Understanding Apollo's API Keys      │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ contributing ┆ Contributing to Rover                │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ docs         ┆ Rover's Documentation Homepage       │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ migration    ┆ Migrate from the Apollo CLI to Rover │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ start        ┆ Getting Started with Rover           │
└──────────────┴──────────────────────────────────────┘

rover subgraph list

prettytable-rs

┌───────┬───────────────────────┬────────────────────────────┐
│ Name  │      Routing Url      │        Last Updated        │
├───────┼───────────────────────┼────────────────────────────┤
│ posts │ http://localhost:4000 │ 2025-02-19 12:04:01 -07:00 │
└───────┴───────────────────────┴────────────────────────────┘

comfy-table

┌───────┬───────────────────────┬────────────────────────────┐
│  Name ┆      Routing Url      ┆        Last Updated        │
╞═══════╪═══════════════════════╪════════════════════════════╡
│ posts ┆ http://localhost:4000 ┆ 2025-02-19 12:04:01 -07:00 │
└───────┴───────────────────────┴────────────────────────────┘

[svc-apollo-docs]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: fb4078d0e5b2347794871e1d

[aaronArinder]

lgtm! though, what was the check_workflow.rs file? just... empty? was it used for anything?

[pubmodmatt]

what was the check_workflow.rs file? just... empty? was it used for anything?

As far as I could tell, it was an empty module not used anywhere, so just some code cleanup there.