Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement supergraph config schema command #2418

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement supergraph config schema command #2418

wants to merge 3 commits into from

Conversation

jonathanrainer
Copy link
Contributor

This takes Dylan's work from #2139 and makes it work with the latest work in Rover

Essentially this allows us to take the work done in apollo-federation-types and expose it for others to consume in other IDEs etc.

@jonathanrainer jonathanrainer requested a review from a team as a code owner February 23, 2025 11:38
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 23, 2025 •
edited
Loading

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed 
* (developer-tools)/rover/commands/supergraphs.mdx

Build ID: d8c4e3294c248982204571b6

URL: https://www.apollographql.com/docs/deploy-preview/d8c4e3294c248982204571b6

@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from f1f3371 to 45950a6 Compare February 23, 2025 11:42
@jonathanrainer jonathanrainer mentioned this pull request Feb 23, 2025
Closed
@jonathanrainer jonathanrainer requested a review from a team as a code owner February 23, 2025 11:58
@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from 940c3f7 to 43f864c Compare February 23, 2025 12:07
@jonathanrainer
Implement print-json-schema command
f6ae108 
This takes Dylan's work from #2139 and makes it work with
the latest work in Rover
@jonathanrainer
Add documentation
514a978
@jonathanrainer
Add E2E test for new command
394e550
@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from 70d4163 to 394e550 Compare February 25, 2025 13:19
@jonathanrainer jonathanrainer changed the title Implement print-json-schema command Implement supergraph config schema command Feb 25, 2025
burn2delete
burn2delete approved these changes Feb 25, 2025
View reviewed changes
Copy link

@burn2delete burn2delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@burn2delete burn2delete burn2delete approved these changes

@aaronArinder aaronArinder aaronArinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanrainer @svc-apollo-docs @burn2delete @aaronArinder