adds docs on using the native GitHub actions #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: b52e04e16e419eb707960712 URL: https://www.apollographql.com/docs/deploy-preview/b52e04e16e419eb707960712 |
Meschreiber
reviewed
Feb 23, 2025
There was a problem hiding this comment.
Thanks for this addition! Beyond the nits I've added as suggestions/comments, a couple of wonderings:
- Should we also update https://www.apollographql.com/docs/graphos/platform/schema-management/checks/github-integration?
- I'm wondering if the H3 orders in the H2 GitHub Actions best fits users' needs. for example, should the new
Apollo-provided GitHub Actionsgo first, followed by[Linux/MacOS jobs using the curl installer](https://www.apollographql.com/docs/deploy-preview/8fc8083fd1146f0f092571d9/rover/ci-cd#linuxmacos-jobs-using-the-curl-installer)then[Displaying schema check results on GitHub pull requests](https://www.apollographql.com/docs/deploy-preview/8fc8083fd1146f0f092571d9/rover/ci-cd#displaying-schema-check-results-on-github-pull-requests)? Or are the following two sub-headers of[Displaying schema check results on GitHub pull requests](https://www.apollographql.com/docs/deploy-preview/8fc8083fd1146f0f092571d9/rover/ci-cd#displaying-schema-check-results-on-github-pull-requests)?
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
|
re:
I think moving them to the same heading level (H3) makes the most sense, since they're all related but not nested. The GitHub app is helpful for both options, but does require a slight bit of configuration in addition to the others. It could live below them- what do you think? |
Meschreiber
approved these changes
Feb 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've moved the GitHub Actions into a more formally supported repo (https://github.com/apollographql/rover-actions), this just updates the docs to point folks there vs. just the cURL example.