Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ROVER-331 Add specific CompositionError handling #2422

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonathanrainer
Copy link
Contributor

@jonathanrainer jonathanrainer commented Feb 25, 2025

Fixes: #2421

It seems that in the move from old to new we got rid of some specific handling around composition errors. This has been re-added

Error From Rover v0.26.3

{"data":{"success":false},"error":{"code":"E029","details":{"build_errors":[{"code":"INVALID_GRAPHQL","message":"[object Object]","nodes":[{"end":null,"source":"@key(\"randomStuff\")\ntype Query {\n    field1: String!\n}","start":null,"subgraph":"fed-service-1"}],"omittedNodesCount":0,"type":"composition"}]},"message":"Encountered 1 build error while trying to build a supergraph."},"json_version":"1"} 

Error from Rover v0.27.2

{"json_version":"1","data":{"success":false},"error":{"message":"Encountered 1 build error while trying to build a supergraph.","code":null}}

Error from this PR

{"json_version":"1","data":{"success":false},"error":{"details":{"build_errors":[{"message":"[object Object]","code":"INVALID_GRAPHQL","type":"composition","nodes":[{"subgraph":"fed-service-1","source":"@key(\"randomStuff\")\ntype Query {\n    field1: String!\n}","start":null,"end":null}],"omittedNodesCount":0}]},"code":"E029","message":"Encountered 1 build error while trying to build a supergraph."}}

It seems that in the move from old to new we got rid of some specific
handling around composition errors. This has been re-added
@jonathanrainer jonathanrainer requested a review from a team as a code owner February 25, 2025 12:52
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 25, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: e103a40b4a2af358c137e3c7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rover supergraph compose errors are missing the code and details
3 participants