fix: dateInput onClose not called with last picked date #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frmalinowski
force-pushed
the
dateinput-onclose-fix
branch
from
3da196e
to
7d3f0a6
Compare
DateInput onClose callback is not called with last picked date when value property is present
frmalinowski
force-pushed
the
dateinput-onclose-fix
branch
from
7d3f0a6
to
4fe2101
Compare
|
Released prerelease version |
JeremyRH
reviewed
Nov 17, 2022
| @@ -274,7 +274,7 @@ export default class DateInput extends React.Component { | |||
| componentDidUpdate(prevProps, prevState) { | |||
| this.setInputValue(); | |||
| if (this.props.onClose && this.state.open !== prevState.open && !this.state.open) { | |||
| const value = this.props.value !== undefined ? this.props.value : this.state.value; | |||
| const value = this.state.value; | |||
There was a problem hiding this comment.
this.state.value can be an empty string even if props.value is provided. Try it by opening the calendar and closing it without selecting a date and providing props.value.
There was a problem hiding this comment.
I think we can fix the issue I mentioned above by changing this line in the contructor:
- let value = props.defaultValue || '';
+ let value = props.value || props.defaultValue || '';
steventhan
force-pushed
the
master
branch
5 times, most recently
from
fc7b9c2
to
440bf24
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateInput onClose callback is not called with last picked date when value property is present