Improve screen recording flow #303
Conversation
|
I don't understand the need for this. The methods need to be added to the clients, to give access to this functionality, rather than clutter up the |
Where exactly they should be added @imurchie ? |
|
I think what @imurchie is saying is that /start_recording_screen and /stop_recording_screen already exist, so we don't need to make |
|
@jlipps I checked the current API endpoint in base driver and I don't find them very flexible and cross-platform. For example, I'd like the stopRecording endpoint to return the taken video immediately. Also, some parameters, which are currently marked as required for start_recording are optional in reality. Don't you mind if I change the endpoints in the base drivers to make them more flexible? |
|
Also, I could add such endpoints to XCTest driver, since iOS simulator also allow to record a video. |
mykola-mokhnach
changed the title
mykola-mokhnach
force-pushed
the
record_screen
branch
from
ec14983 to
9363788
Compare
| return `${bytes} B`; | ||
| } | ||
|
|
||
| async function uploadRecordedMedia (adb, pathOnDevice, remotePath = null, uploadOptions = {}) { |
There was a problem hiding this comment.
all these helper functions can be also reused in iOS. Perhaps, we could move them to some common lib. the only question is to what lib
There was a problem hiding this comment.
The only place would be appium-support.
|
Thank you so much for this code update. Happy that there are amazing dedicated people improving Appium. Looking forward to using this with the Python client. |
I've changed the logic here, so now it's much simpler to get the result of the screen record. there is also a possibility to upload the file to a remote location using ftp/http protocols and protection from OOM issues.
Related base driver PR: appium/appium-base-driver#168
I'll also take care about finishing the java client implementation (the PR is there, but it has been waiting for almost a year).