Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Update Simulator preferences configuration #347

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

mykola-mokhnach
Copy link
Contributor

There is no need to restart Simulator in order to apply its preferences (and it does not work as well).
The right way of doing that now is by invoking defaults CLI. It also notifies cfprefsd, so various apps and services could pick up settings change in runtime.

cc @rerorero

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't see anything about not restarting the sim anymore?

@mykola-mokhnach
Copy link
Contributor Author

LGTM but I don't see anything about not restarting the sim anymore?

It's done in xcuitest driver. I'll change the implementation as soon as this patch is published

@mykola-mokhnach mykola-mokhnach merged commit 355c5da into appium:master Dec 12, 2022
@mykola-mokhnach mykola-mokhnach deleted the safari_settings branch December 12, 2022 17:04
github-actions bot pushed a commit that referenced this pull request Dec 12, 2022
## [4.2.1](v4.2.0...v4.2.1) (2022-12-12)

### Bug Fixes

* Update Simulator preferences configuration ([#347](#347)) ([355c5da](355c5da))

### Code Refactoring

* do not launch in setReduceMotion ([#343](#343)) ([cc35e3e](cc35e3e))
* Drop usage of fs-extra module ([#344](#344)) ([4c1a63e](4c1a63e))
* Streamline settings helpers for the simulator ([#346](#346)) ([bcf4753](bcf4753))
@github-actions
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants