fix: filter out new in java16+ method(s) from proxy class for by-builder #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AppiumByBuilder. [appium#1575](appium#1575)
|
|
…+) in AppiumByBuilder
ayuryev
changed the title
ayuryev
changed the title
ayuryev
changed the title
src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java
Show resolved
Hide resolved
valfirst
requested changes
Nov 5, 2021
src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>
valfirst
reviewed
Nov 5, 2021
valfirst
approved these changes
Nov 5, 2021
|
@mykola-mokhnach could you merge this fix into 7.6.x version? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… AppiumByBuilder. #1575
Change list
Filter out proxyClassLookup method from Proxy class (for Java 16+) in AppiumByBuilder. #1575
Types of changes
Details
Avoid getting java.lang.NoSuchMethodException when loading PageFactory elements in Java16+