Skip to content

ci: Move execution of E2E tests to GitHub Actions #1913

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

valfirst
Copy link
Collaborator

Change list

CI: Move execution of E2E tests to GitHub Actions

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

  • Single tool for CI
  • Results of previous stages (installations, downloads, Gradle task results, etc.) are reused by subsequent stages
    • faster execution
    • no execution of stages if any previous one fails

@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch 2 times, most recently from f3b48f4 to ea7aaf3 Compare May 10, 2023 10:31
@valfirst valfirst marked this pull request as draft May 10, 2023 10:45
@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from ea7aaf3 to 3089c64 Compare May 10, 2023 10:47
@saikrishna321
Copy link
Member

@valfirst Any reason to move to GitActions from Azure?

@valfirst
Copy link
Collaborator Author

@saikrishna321 please check Details section in the initial PR comment, IMHO it's better to have a single CI tool

@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from 3089c64 to 77b94d1 Compare May 10, 2023 11:18
@valfirst valfirst marked this pull request as ready for review May 10, 2023 12:38
@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from 77b94d1 to 9965ccc Compare May 11, 2023 07:08
java: [ 8, 11, 17 ]
include:
- java: 8
platform: macos-latest
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might break in the future because Xcode/simulator versions are tied to macOS version. That is why it makes sense to keep them as constants in the same group, so one could update their values in a single shot. Also put a specific OS version instead of the latest

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for iOS tests (see java 11 + macOS 12)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the explanation comment below why mac os version for ios tests must not be set to latest

@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch 2 times, most recently from f7742af to 4d74024 Compare May 11, 2023 10:56
@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch 2 times, most recently from 3ffe88b to 2f96ffd Compare May 11, 2023 13:29
@mykola-mokhnach
Copy link
Contributor

it looks like both integration tests don't do well yet :(

@valfirst
Copy link
Collaborator Author

https://www.githubstatus.com/ :

Update - Actions, Git Operations, Pages and Webhooks are experiencing degraded performance. We are continuing to investigate.
May 11, 2023 - 13:35 UTC
Investigating - We are investigating reports of degraded performance for Issues and Pull Requests.
May 11, 2023 - 13:33 UTC

it seems it's global GitHub outage

@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from 2f96ffd to c47b859 Compare May 11, 2023 15:11
@mykola-mokhnach
Copy link
Contributor

    Caused by:
   org.openqa.selenium.net.UrlChecker$TimeoutException: Timed out waiting for [http://127.0.0.1:4723/status] to be available after 20148 ms

Perhaps we need to increase the default timeout for the Appium startup. 20 seconds is not enough for the slow CI

@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from c47b859 to 6d21f99 Compare May 12, 2023 06:52
@valfirst valfirst force-pushed the move-execution-of-e2e-tests-to-github-actions branch from 6d21f99 to 0d0b854 Compare May 12, 2023 07:21
@mykola-mokhnach
Copy link
Contributor

I am happy to marge the PR as soon as all tests are green

@mykola-mokhnach mykola-mokhnach merged commit 4560e23 into appium:master May 13, 2023
@valfirst valfirst deleted the move-execution-of-e2e-tests-to-github-actions branch May 15, 2023 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants