Fix complexFind. Add scrollTo, scrollToExact #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| element.setParent(driver); | ||
| element.setId(elementId); | ||
| element.setFileDetector(driver.getFileDetector()); | ||
| return element; |
There was a problem hiding this comment.
This method could instead return class MobileElement.
return new MobileElement(element, driver);
Then all the elements returned by complexFind can be easily cast to MobileElement.
Additionally, can we have all the methods in this class return MobileElement rather than WebElement. Since driver has to be an instance of AppiumDriver, might as well always return MobileElements
|
@Jonahss Updated |
Jonahss
added a commit
that referenced
this pull request
May 19, 2014
Fix complexFind. Add scrollTo, scrollToExact
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25