Appknox-Go: Region and Host functionality #52
Conversation
cmd/root.go
Outdated
| RootCmd.PersistentFlags().String("region", "", "Region names, e.g., global, saudi, uae. By default, global is used") | ||
| viper.BindPFlag("region", RootCmd.PersistentFlags().Lookup("region")) | ||
| viper.BindEnv("region", "APPKNOX_API_REGION") | ||
| viper.SetDefault("region", "") |
There was a problem hiding this comment.
The default is suppose to be global. Can we add it here?
helper/clientInitialize.go
Outdated
| if host == "" { | ||
| if region != "" { | ||
| // Check if region exists in the mappings | ||
| if mappedHost, exists := hostMappings[region]; exists { | ||
| host = mappedHost | ||
| } else { | ||
| // Invalid region, throw error and show available regions | ||
| availableRegions := make([]string, 0, len(hostMappings)) | ||
| for key := range hostMappings { | ||
| availableRegions = append(availableRegions, key) | ||
| } | ||
| fmt.Printf("Invalid region name: %s. Available regions: %s\n", region, strings.Join(availableRegions, ", ")) | ||
| os.Exit(1) | ||
| } | ||
| } else { | ||
| // If neither host nor region are provided, default to the global host | ||
| host = hostMappings["global"] | ||
| } | ||
| } else { | ||
| // If both region and host are provided, prioritize host and ignore region |
There was a problem hiding this comment.
can we move this logic to a separate function along with tests? There is too much nested if here without tests?
the function should probably accept the host env and region env and return (baseurl, error) with similar logic.
There was a problem hiding this comment.
Yes, moved the logic to a separate function.
helper/clientInitialize.go
Outdated
| func getAPIHostMappings() map[string]string { | ||
| // Instead of using an environment variable, call the new function | ||
| return GetHostMappings() | ||
| } | ||
|
|
There was a problem hiding this comment.
Is the function needed? GetHostMappings doing the same thing.
There was a problem hiding this comment.
Yes, the function is redundant, fixed that.
|
Added a region flag, and now host takes url only, and region takes names only