Skip to content

Torch eq and ne ops supports bool type. #1501

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2022
Merged

Torch eq and ne ops supports bool type. #1501

merged 3 commits into from
Jun 16, 2022

Conversation

fukatani
Copy link
Contributor

I found eq and ne ops does not support bool type since mb.equals and mb.not_equals does not support bool.

@TobyRoseman
Copy link
Collaborator

The diff here is deleting unrelated unit tests. I think you started this branch off an earlier commit without those unit tests.

Please rebase your changes on top of the latest main.

@fukatani
Copy link
Contributor Author

@TobyRoseman
Thanks!
I rebased this PR on latest master and removed unrelated diffs.

ArjunSharda
ArjunSharda suggested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@ArjunSharda ArjunSharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this PR's code is not up to date with the latest code, so I suggest updating when out of date so it has a potential to be merged if everything is good.

@fukatani
Copy link
Contributor Author

I updated this branch.

@ArjunSharda
Copy link
Contributor

Thanks

@TobyRoseman TobyRoseman merged commit aeb3e8e into apple:main Jun 16, 2022
@TobyRoseman
Copy link
Collaborator

Thanks @fukatani

dncnbuck pushed a commit to dncnbuck/coremltools that referenced this pull request Jul 5, 2022
@fukatani @dncnbuck
Torch eq and ne ops supports bool type. (apple#1501)
d13735d 
* Torch eq and ne ops supports bool type.

* Addressed review comment
dncnbuck pushed a commit to dncnbuck/coremltools that referenced this pull request Sep 3, 2022
@fukatani @dncnbuck
Torch eq and ne ops supports bool type. (apple#1501)
1f29b6a 
* Torch eq and ne ops supports bool type.

* Addressed review comment
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ArjunSharda ArjunSharda ArjunSharda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fukatani @TobyRoseman @ArjunSharda