API Reference for v6.0b1 and Layernorm Fix #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybove-apple
added
the
docs
|
@tonybove-apple - I'm seeing the |
@TobyRoseman : Sorry, the other changes are not part of this PR, but were done somewhere along the line by @aseemw or whoever edited the internal version of the docstrings -- in the case of the compression utilities, I edited the docstrings. But these changes were approved in the internal repo before this PR. However, this is the first time they appear in this public repo, and the first time the HTML for it will be generated (the next PR). So the only change to review is in |
aseemw
approved these changes
Jun 8, 2022
TobyRoseman
approved these changes
Jun 8, 2022
dncnbuck
pushed a commit
to dncnbuck/coremltools
that referenced
this pull request
Jul 5, 2022
dncnbuck
pushed a commit
to dncnbuck/coremltools
that referenced
this pull request
Sep 3, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the API Reference documentation as follows:
normalization.py:layer_normcorrection togammaandbetaparameters (rdar://94354229).Note: Changes to docstrings in 6.0b1, including new compression utilities under Models, and new output specification for
convert(), were done and approved in the internal repo before this PR. However, this is the first time they appear in this public repo.This PR does not include the generated HTML. After these changes are
reviewed and merged, I will do a separate PR to merge the HTML.