Fix a bug when destructing coreml model #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseemw
reviewed
Jun 8, 2022
| @@ -363,6 +363,8 @@ def __del__(self): | |||
| # Cleanup temporary package upon destruction | |||
| if hasattr(self, 'is_package') and self.is_package \ | |||
| and hasattr(self, 'is_temp_package') and self.is_temp_package: | |||
| if _shutil is None: | |||
| import shutil as _shutil | |||
| _shutil.rmtree(self.package_path) | |||
There was a problem hiding this comment.
isn't the issue in the line _shutil.rmtree(self.package_path) ? if the self.package_path is None or empty and hence there is nothing to remove?
There was a problem hiding this comment.
It is because the package itself (shutil) is destructed before this del function is called
aseemw
approved these changes
Jun 8, 2022
TobyRoseman
approved these changes
Jun 8, 2022
jakesabathia2
force-pushed
the
eng/PR-fix-destructor
branch
from
42eb3a3 to
902da8f
Compare
dncnbuck
pushed a commit
to dncnbuck/coremltools
that referenced
this pull request
Jul 5, 2022
Fix a bug when destructing coreml model (apple#1515)
dncnbuck
pushed a commit
to dncnbuck/coremltools
that referenced
this pull request
Sep 3, 2022
Fix a bug when destructing coreml model (apple#1515)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1512