Skip to content

Update AdjacentPairs implementations and tests #139

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2021
Merged

Update AdjacentPairs implementations and tests #139

merged 3 commits into from
May 5, 2021

Conversation

natecook1000
Copy link
Member

Update the AdjacentPairs implementation based on code review in #119.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000 natecook1000 requested a review from timvermeulen May 5, 2021 04:42
@natecook1000
Apply suggestions from code review
9b173fa 
Co-authored-by: Tim Vermeulen <tvermeulen@apple.com>
@natecook1000
Copy link
Member Author

@swift-ci Please test

@timvermeulen
Copy link
Contributor

🎉

@timvermeulen timvermeulen merged commit 65ef6cb into main May 5, 2021
@timvermeulen timvermeulen deleted the nate/pairs branch May 5, 2021 17:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@timvermeulen timvermeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natecook1000 @timvermeulen