Add additional tests to rotate functions, clarify variable names #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rotate
functions. It’s good to specifically test the examples in the documentation. After all, those are the cases that are absolutely expected to work._reverse(subrange:until:)
andreverse(subrange:)
_reverse(subrange:until:)
, uselower
andupper
instead off
andl
.l
could easily be misinterpreted aslower
,left
, orlimit
. Usinglower
andupper
avoids this ambiguity.lower
andupper
instead oflo
, andhi
, respectively, inreverse(subrange:)
. This is more consistent withlowerBound
andupperBound
.Checklist