Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make the usual pthread changes for OpenBSD. #239

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Conversation

3405691582
Copy link
Contributor

No description provided.

Copy link
Member

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have thought a bit about if we can move to Mutex from the standard library but this will likely never be fully possible without a semver major because Mutex is only available on macOS 15.0+ and aligned releases but we support 10.15 :/

However, we could only move to Mutex on new platforms like OpenBSD. That means we would need to use our own lock wrapper on darwin platforms but could use Mutex on all other platforms. This is somewhat desirable as we would get support for any new platform that the standard library supports for free.

As Mutex is only available in Swift 6+ toolchains we would also need to add some more #if's to actually make this work.
Not sure if it is worth the effort while we still support non Swift 6 toolchains.

@dnadoba dnadoba added the 🆕 semver/minor Adds new public API. label Mar 29, 2025
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Lukasa Lukasa enabled auto-merge (squash) April 9, 2025 10:28
@Lukasa Lukasa merged commit 63d06f4 into apple:main Apr 9, 2025
35 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants