Adopt Sendable in NIOExtras
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental `Sendable` adoption.
Lukasa
requested changes
Aug 23, 2022
| public var cumulationBuffer: ByteBuffer? { | ||
| get { nil } | ||
| set { /* discard newValue */ } | ||
| } |
There was a problem hiding this comment.
I don't think we can safely make this behavioural change. Given that there's no particular reason to require this type to be Sendable, I propose we mark it "explicitly not Sendable" and tolerate that.
There was a problem hiding this comment.
Agree, that's the better solution. Shortly thought about making FixedLengthFrameDecoder a struct instead of a class but that would be a source breaking change too.
Changed in daae52c
Lukasa
approved these changes
Aug 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental
Sendableadoption.