Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enable automatic compression format detection #208

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Enable automatic compression format detection #208

merged 2 commits into from
Mar 26, 2024

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Oct 6, 2023

Motivation:

Some servers can announce the wrong compression format. We should autodetect the format used through header detection of the compressed data.

Modifications:

  • enable zlibs automatic compression format detection

Result:

We can decompress wrongly advertised requests and responses.

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Oct 6, 2023
Lukasa
Lukasa approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but this looks good.

@Lukasa Lukasa enabled auto-merge (squash) March 26, 2024 09:53
@Lukasa Lukasa merged commit 8b9030d into apple:main Mar 26, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @Lukasa