don't crash if user tried to use private key without password #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
commented
Jul 31, 2019
weissi
commented
Jul 31, 2019
weissi
force-pushed
the
jw-no-password-dont-crash
branch
from
e4856d5 to
8c765c4
Compare
weissi
force-pushed
the
jw-no-password-dont-crash
branch
from
8c765c4 to
20bc66c
Compare
|
@Lukasa ok, updated |
weissi
force-pushed
the
jw-no-password-dont-crash
branch
from
20bc66c to
c095f58
Compare
Lukasa
added
🔨 semver/patch
Motivation: Previously, if the user tried to open a private key that had a password but didn't specify one, we would just crash. Modifications: Throw an error instead of crashing if no password was supplied but one was needed. Result: Fewer crashes.
weissi
force-pushed
the
jw-no-password-dont-crash
branch
from
81e389e to
3f64e77
Compare
|
should be addressed by apple/swift-nio#1093 |
Lukasa
approved these changes
Aug 7, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously, if the user tried to open a private key that had a password
but didn't specify one, we would just crash.
Modifications:
Throw an error instead of crashing if no password was supplied but one
was needed.
Result:
Fewer crashes.