Enhance CircularBuffer with insertFirst and popFirst/Last

[helje5]

I'd like to abuse the CircularBuffer as a CoW data structure w/ linked list behaviour (better index-0 insert/remove behaviour than ContiguousArray, which I currently use). Since the ivars are all private, I can't extend CircularBuffer with the operations I need. I think it would be those (also available in the stdlib, excluding insertFirst):

public mutating func popFirst() -> Element?
public mutating func popLast() -> Element?
public mutating func insertFirst(Element)

Would be great to get those (and a CoW linked list ;-) )

[weissi]

sure, we can totally just implement the missing methods. @Lukasa / @normanmaurer opinions?

[Lukasa]

Eh, sure, why not?

[normanmaurer]

If we can without any perf hit for our use-case I am in

…

Am 05.04.2018 um 10:46 schrieb Cory Benfield ***@***.***>: Eh, sure, why not? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[normanmaurer]

@helje5 btw we love PRs :)

[helje5]

Every one loves PRs! But then @Lukasa wants you to write tests for perfectly working code and a 2 minute patch becomes hours and hours. Been there, done that ;-)

But yes, I consider doing a PR. I need to fully understand it to do the insertFirst right, the only reason I didn't approach that yet (apart from the fact that it would probably take @weissi 2 minutes to do those 😉)

[Lukasa]

I'm a monster, I know. And yet I feel so little guilt!

[Lukasa]

(Also I'd definitely make @weissi write the tests too.)

[normanmaurer]

@Lukasa maybe I should write the patch then as it seems I will not need to write tests 🤷‍♂️ ;)

[normanmaurer]

I will take a stab on this once #313 is merged