TestUtils: EventCounterHandler #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
May 17, 2019
| } | ||
| } | ||
|
|
||
| private let _channelRegisteredCalls = Atomic<Int>(value: 0) |
There was a problem hiding this comment.
Jees, I really want some property delegates now to ease all of this boilerplate!
weissi
force-pushed
the
jw-event-counter-handler
branch
2 times, most recently
from
51fc673 to
c8c4c9a
Compare
Motivation: In many unit tests, it's important to count the events. So far we have many many ad-hoc handlers to do so but having one that counts all events would be handy. Modifications: Add `EventCounterHandler` to count all events travelling the `ChannelPipeline`. Result: Easier unit testing
weissi
force-pushed
the
jw-event-counter-handler
branch
from
c8c4c9a to
d7d8fff
Compare
Lukasa
approved these changes
May 17, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In many unit tests, it's important to count the events. So far we have
many many ad-hoc handlers to do so but having one that counts all events
would be handy.
Modifications:
Add
EventCounterHandlerto count all events travelling theChannelPipeline.Result:
Easier unit testing