check breakages: fail loudly when unable to checkout tag #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One line description of your change Motivation: When using the script ad hoc to verify something you may have forgotten to pull all tags, the script then fails mysteriously in silence and no output. Detective work can then lead the script mysteriously stopping after a checkout: ``` + cd /tmp/.check-api_1Q1rvO/repo + git checkout 1.1.0 $ ... ``` which reminds you to perform a fetch; it would be nicer if it told us about the issue explicitly though. Modifications: Don't silence `git checkout` all error output, though use quiet mode so no progress is printed. Result: Script fails nicer and reminds you to perform a git fetch if you forgot to do so. e.g. ``` [5/5] Merging module Metrics error: pathspec '1.1.0' did not match any file(s) known to git ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of your change
Motivation:
When using the script ad hoc to verify something you may have forgotten to pull all tags,
the script then fails mysteriously in silence and no output. Detective work can then lead the script mysteriously stopping after a checkout:
which reminds you to perform a fetch; it would be nicer if it told us about the issue explicitly though.
Modifications:
Don't silence
git checkoutall error output, though use quiet mode so no progress is printed.Result:
Script fails nicer and reminds you to perform a git fetch if you forgot to do so.
e.g.