Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

workaround SR-11143 for api-digester: pass -sdk / on Linux #1068

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented Jul 16, 2019

Motivation:

swift-api-digester requires to be passed -sdk / on Linux.

Modifications:

Pass -sdk / on Linux and the SDK directory on Darwin.

Result:

check_no_api_breakages works on Linux.

Motivation:

swift-api-digester requires to be passed `-sdk /` on Linux.

Modifications:

Pass `-sdk /` on Linux and the SDK directory on Darwin.

Result:

check_no_api_breakages works on Linux.
@weissi weissi requested a review from Lukasa July 16, 2019 11:28
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Jul 16, 2019
@Lukasa Lukasa added this to the 2.5.0 milestone Jul 16, 2019
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@weissi weissi merged commit 5f8d3f0 into apple:master Jul 16, 2019
@weissi weissi deleted the jw-workaround-SR-11143 branch July 16, 2019 11:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants