dev/stackdiff-dtrace: stack aggregation diffing script #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-stackdiff-dtrace
branch
from
4b3fdc5 to
623c1ec
Compare
Lukasa
requested changes
Jan 31, 2020
Motivation: NIO has allocation counter tests, NIO also has dev/malloc-aggregation.d which can give you aggregated stacks that allocated alongside how many times they allocated. What's missing is a script that can diff two aggregated stack traces. Modifications: Add dev/stacktrace-dtrace which allows aggregated stack trace diffing. Result: Easier to track performance regressions.
weissi
force-pushed
the
jw-stackdiff-dtrace
branch
from
623c1ec to
59fc300
Compare
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Feb 3, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIO has allocation counter tests, NIO also has dev/malloc-aggregation.d
which can give you aggregated stacks that allocated alongside how many
times they allocated. What's missing is a script that can diff two
aggregated stack traces.
Modifications:
Add dev/stacktrace-dtrace which allows aggregated stack trace diffing.
Result:
Easier to track performance regressions.