NIO: excise UDS support for Windows #1404
Conversation
|
Can one of the admins verify this patch? |
9 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
One question that comes to mind: should this be a general option rather than platform conditional? I imagine that WASM may not implement UDS either and so more than just windows would want the |
This removes support for Unix Domain Sockets from NIO on Windows. Although Windows 10.17063 introduced basic support for UDS, the support is incomplete and has differences from the tradtional UDS sockets in terms of behaviour. Excise the support initially to get NIO to build on Windows.
compnerd
force-pushed
the
unix-is-not-in-the-domain
branch
from
6c60ef5 to
469c92c
Compare
WASM will want a lot more removed than just UDS, I think: NIO won't function at all on WASM as it relies on far too much of the system. When WASM becomes something we really want to worry about we may need to consider a substantial refactor of the APIs. In particular, we probably will need to separate the bits of NIO that are truly platform agnostic (things like protocols, I don't think we want to go too far down that road today, because it's a pretty substantial breaking change, but if we want to get serious about WASM it'll necessarily come up. |
|
I'm marking this as a Semver patch because, well, we never worked on Windows before so this can't break existing APIs. |
|
@swift-nio-bot test this please |
This removes support for Unix Domain Sockets from NIO on Windows.
Although Windows 10.17063 introduced basic support for UDS, the support
is incomplete and has differences from the tradtional UDS sockets in
terms of behaviour. Excise the support initially to get NIO to build on
Windows.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]