use Posix.read instead of Glibc.read for timerfd #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Mar 4, 2020
Sources/NIO/Selector.swift
Outdated
| @@ -549,7 +549,7 @@ internal class Selector<R: Registration> { | |||
| // Consume event | |||
| var val: UInt64 = 0 | |||
| // We are not interested in the result | |||
| _ = Glibc.read(self.timerFD, &val, MemoryLayout.size(ofValue: val)) | |||
| _ = try! Posix.read(self.timerFD, &val, MemoryLayout.size(ofValue: val)) | |||
There was a problem hiding this comment.
Looks like you're missing some labels here:
swift-nio/Sources/NIO/System.swift
Line 396 in 546a84c
There was a problem hiding this comment.
Thanks for checking. I am figuring out the values.
glbrntt
approved these changes
Mar 4, 2020
weissi
approved these changes
Mar 4, 2020
|
@swift-nio-bot test this please |
|
I didn't understand the CI error. Please help me to understand it. |
|
ignore it, our CI is underpowered is what that means :( |
|
@swift-nio-bot test this please |
|
Thanks! :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To read the bytes from
timerfd, we use Glibc.read directly but we should usetry! Posix.readModifications:
Using
Posixinstead ofGlibcfor read operation withtry!to check for any error.Result:
Fixes #1341