NIO: use Posix "namespace" more aggressively
#1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Mar 11, 2020
|
Im very confused why I didn't need the conversion :/ |
Convert many more cases of the raw address family constant to the definition in the System version.
|
@swift-nio-bot test this please |
|
I think they're only necessary on Linux due to a mismatch in the way the constants are declared and the way they're used. |
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
Mar 11, 2020
Convert many more cases of the raw address family constant to the definition in the System version.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert many more cases of the raw address family constant to the
definition in the System version.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]