downgrade 'schedule after shutdown' to printing error #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Since apple#1395, we crash when something is scheduled to an already shutdown EventLoop. That's a good intent (apple#1383) but we feel it's a little too risky right now. Modifications: Print an ERROR instead of just crashing. Result: Fewer crashes.
weissi
force-pushed
the
jw-downgrade-crash
branch
from
6bc8be6 to
d2d9f8c
Compare
Lukasa
approved these changes
Mar 18, 2020
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
Mar 18, 2020
Motivation: Since apple#1395, we crash when something is scheduled to an already shutdown EventLoop. That's a good intent (apple#1383) but we feel it's a little too risky right now. Modifications: Print an ERROR instead of just crashing. Result: Fewer crashes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since #1395, we crash when something is scheduled to an already shutdown
EventLoop. That's a good intent (#1383) but we feel it's a little too
risky right now.
Modifications:
Print an ERROR instead of just crashing.
Result:
Fewer crashes.