-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convenient initialisers from ByteBuffer
#1457
Convenient initialisers from ByteBuffer
#1457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need the separate files for each of these: they can all go in ByteBuffer-aux
except for the Data
one which can just go next to readData
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks very useful, left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teeny tiny notes here, this patch looks great otherwise.
Co-Authored-By: Cory Benfield <lukasa@apple.com>
…e94/swift-nio into de/convenient-buffer-initialisers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Whoop, missed review here -- sorry fixed my email settings / filters a bit recently :-) LGTM, really nice to see this one |
Added simple initialisers to various types that consume a
ByteBuffer
.Motivation:
Common operations to read a
ByteBuffer
as some different typeT
were a little too verbose.Modifications:
New initialisers for:
Result: