shorten NIOThreadPool's thread names #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Previously, NIOThreadPool would use super long thread names. Linux doesn't allow more than 15 bytes (+ \0 char) so in the end they would never get set at all. Modifications: - Shorten NIOThreadPool's thread names - Only take the first 15 characters of thread names in general on Linux Result: We don't lose thread names on Linux.
Lukasa
approved these changes
Mar 31, 2020
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
Mar 31, 2020
Motivation: Previously, NIOThreadPool would use super long thread names. Linux doesn't allow more than 15 bytes (+ \0 char) so in the end they would never get set at all. Modifications: - Shorten NIOThreadPool's thread names - Only take the first 15 characters of thread names in general on Linux Result: We don't lose thread names on Linux.
glbrntt
reviewed
Apr 1, 2020
| @@ -175,7 +175,8 @@ public final class NIOThreadPool { | |||
|
|
|||
| for id in 0..<self.numberOfThreads { | |||
| group.enter() | |||
| NIOThread.spawnAndRun(name: "NIOThreadPool thread #\(id)", detachThread: false) { thread in | |||
| // We should keep thread names under 16 characters because Linux doesn't allow more. | |||
| NIOThread.spawnAndRun(name: "TP-#\(id)", detachThread: false) { thread in | |||
There was a problem hiding this comment.
I know I missed the boat on this one, but there may be some value in having NIO in the name: "NIOTP-#\(id)" perhaps?
There was a problem hiding this comment.
@glbrntt this time I deliberately left NIO out because we got so many bug reports about crashes if there's NIO in it :D . People thing that all crashes on NIO* threads are NIO's fault :|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously, NIOThreadPool would use super long thread names. Linux
doesn't allow more than 15 bytes (+ \0 char) so in the end they would
never get set at all.
Modifications:
Result:
We don't lose thread names on Linux.