Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update supported version in README #1517

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Update supported version in README #1517

merged 5 commits into from
Jun 18, 2020

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented May 13, 2020

Motivation:

NIO can run on macOS 10.10+, but the README states 10.12+.

Modifications:

Update readme.

Result:

More accurate docs.

Motivation:

NIO can run on macOS 10.10+, but the README states 10.12+.

Modifications:

Update readme.

Result:

More accurate docs.
@Lukasa Lukasa requested a review from weissi May 13, 2020 15:22
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label May 13, 2020
@Lukasa Lukasa added this to the 2.18.0 milestone May 13, 2020
@glbrntt
Copy link
Contributor Author

glbrntt commented May 19, 2020

@swift-nio-bot test this please

@weissi
Copy link
Member

weissi commented May 19, 2020

@glbrntt we could even add macOS 10.9 and iOS 7 :)

@glbrntt
Copy link
Contributor Author

glbrntt commented May 19, 2020

@weissi ah neat, will add. We should make our pods consistent with that as well:

s.ios.deployment_target = '10.0'
s.osx.deployment_target = '10.10'
s.tvos.deployment_target = '10.0'

@weissi weissi merged commit 7100980 into apple:master Jun 18, 2020
@Lukasa Lukasa modified the milestones: 2.18.0, 2.19.0 Jun 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants