remove XCTest expectations with timeouts #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The XCTest expectations caused problems when they time out. When they time out, the execution continues which in the tests in question then shut down the EventLoop. Shutting down the event loop meant that other things don't happen which caused the test to hang. The XCTest expectations however tell us about the failure at the end of the test (which we never reach). Modifications: Remove the XCTest expectations with timeouts. Result: Even slow CI should pass this test correctly.
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
Jun 2, 2020
Motivation: The XCTest expectations caused problems when they time out. When they time out, the execution continues which in the tests in question then shut down the EventLoop. Shutting down the event loop meant that other things don't happen which caused the test to hang. The XCTest expectations however tell us about the failure at the end of the test (which we never reach). Modifications: Remove the XCTest expectations with timeouts. Result: Even slow CI should pass this test correctly. Co-authored-by: Cory Benfield <lukasa@apple.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The XCTest expectations caused problems when they time out. When they
time out, the execution continues which in the tests in question then
shut down the EventLoop. Shutting down the event loop meant that other
things don't happen which caused the test to hang. The XCTest
expectations however tell us about the failure at the end of the test
(which we never reach).
Modifications:
Remove the XCTest expectations with timeouts.
Result: