Allow Metadata to be constructed and set on AddressedEnvelope #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This needs to be possible so users can specify what ECN status they wish to send. The auto-generated initialiser is internal. Modifications: Add public initialiser to AddressedEnvelope.Metadata Add public initialiser to AddressedEnvelope taking Metadata Result: Users will be able to construct AddressedEnvelopes with Metadata set.
Lukasa
approved these changes
Jul 14, 2020
|
@swift-nio-bot test this please |
5 tasks
slashmo
pushed a commit
to slashmo/swift-nio
that referenced
this pull request
Aug 18, 2020
…1591) Motivation: This needs to be possible so users can specify what ECN status they wish to send. The auto-generated initialiser is internal. Modifications: Add public initialiser to AddressedEnvelope.Metadata Add public initialiser to AddressedEnvelope taking Metadata Result: Users will be able to construct AddressedEnvelopes with Metadata set.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This needs to be possible so users can specify what
ECN status they wish to send. The auto-generated
initialiser is internal.
Modifications:
Add public initialiser to AddressedEnvelope.Metadata
Add public initialiser to AddressedEnvelope taking Metadata
Result:
Users will be able to construct AddressedEnvelopes with Metadata set.