fix EventLoopFuture.and's serious threading issues [alternative] #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: EventLoopFuture.and had serious threading issues if the EventLoops weren't the same. Modifications: Fixed the threading issues and tested them properly. Result: Hopefully `and` and `andAll` now don't crash if you use them across EventLoops.
weissi
force-pushed
the
jw-fix-future-and-threading-alt
branch
from
18fafdb to
ab05365
Compare
Lukasa
approved these changes
Mar 16, 2018
|
thanks for pushing me to do something @Lukasa , thought the alternatives would be too risky (in perf/bugs) but wasn't quite right ;) |
| _whenComplete { () -> CallbackList in | ||
| switch self.value! { | ||
| case .failure(let error): | ||
| return promise._setValue(value: .failure(error)) | ||
| case .success(let t): | ||
| andlock.lock() |
normanmaurer
approved these changes
Mar 16, 2018
tiagomartinho
pushed a commit
to tiagomartinho/swift-nio
that referenced
this pull request
Mar 17, 2018
Motivation: EventLoopFuture.and had serious threading issues if the EventLoops weren't the same. Modifications: Fixed the threading issues and tested them properly. Result: Hopefully `and` and `andAll` now don't crash if you use them across EventLoops.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: The code-of-conduct email address is out-of-date. Modifications: Update code-of-conduct email address to swift-server-conduct@group.apple.com Result: - Code of conduct email address is up-to-date.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
Motivation Currently we don't confirm that the decompression has completed successfully. This means that we can incorrectly spin forever attempting to decompress past the end of a message, and that we can fail to notice that a message is truncated. Neither of these is good. Modifications Propagate the message zlib gives us as to whether or not decompression is done, and keep track of it. Add some tests written by @vojtarylko to validate the behaviour. Result Correctly police the bounds of the messages. Resolves apple#175 and apple#176.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #175
Motivation:
EventLoopFuture.and had serious threading issues if the EventLoops
weren't the same.
Modifications:
Fixed the threading issues and tested them properly.
Result:
Hopefully
andandandAllnow don't crash if you use them acrossEventLoops.