Suppress compiler warnings in release mode. #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There's no reason for us to emit compiler warnings. Modifications: Remove use of _isDebugAssertConfiguration to guard code, instead use a hand-rolled hacky solution on top of assert. Result: Fewer warnings, more sadness.
|
Confirmed this is optimised away in release mode. |
normanmaurer
approved these changes
Mar 16, 2018
|
Ugly, but works |
tiagomartinho
pushed a commit
to tiagomartinho/swift-nio
that referenced
this pull request
Mar 17, 2018
Motivation: There's no reason for us to emit compiler warnings. Modifications: Remove use of _isDebugAssertConfiguration to guard code, instead use a hand-rolled hacky solution on top of assert. Result: Fewer warnings, more sadness.
weissi
added a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There's no reason for us to emit compiler warnings.
Modifications:
Remove use of _isDebugAssertConfiguration to guard code, instead
use a hand-rolled hacky solution on top of assert.
Result:
Fewer warnings, more sadness.
Resolves #178.