Return failed EventLoopFuture when getOption(...) / setOption(...) is… #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
options_closed_channel
branch
from
c4e8b03 to
d01b92d
Compare
normanmaurer
force-pushed
the
options_closed_channel
branch
3 times, most recently
from
3e63e63 to
6c6fa7f
Compare
Lukasa
requested changes
Mar 20, 2018
|
|
||
| try assertSetGetOptionOnOpenAndClosed(channel: clientChannel, option: ChannelOptions.allowRemoteHalfClosure, value: true) | ||
| try assertSetGetOptionOnOpenAndClosed(channel: serverChannel, option: ChannelOptions.backlog, value: 100) | ||
| } |
There was a problem hiding this comment.
Can you do this for datagram channels too?
normanmaurer
force-pushed
the
options_closed_channel
branch
from
6c6fa7f to
4239216
Compare
|
@Lukasa always forget about |
normanmaurer
force-pushed
the
options_closed_channel
branch
2 times, most recently
from
ed36067 to
872f13f
Compare
weissi
requested changes
Mar 20, 2018
Sources/NIO/SocketChannel.swift
Outdated
| @@ -284,6 +284,10 @@ class BaseSocketChannel<T: BaseSocket>: SelectableChannel, ChannelCore { | |||
| fileprivate func setOption0<T: ChannelOption>(option: T, value: T.OptionType) throws { | |||
| assert(eventLoop.inEventLoop) | |||
|
|
|||
| guard isOpen else { | |||
| throw ChannelError.alreadyClosed | |||
There was a problem hiding this comment.
.alreadyClosed is defined as only close on already closed channel. This should be ioOnClosedChannel
… called on a closed Channel Motivation: We should return a failed EventLoopFuture when getOption(...) / setOption(...) is called on a closed Channel as otherwise it may not be safe to modify the Channel ioptions after its closed. Modifications: - Add guards that check if the Channel is still open and if not fail the operation. - Add testcase Result: Calling getOption(...) / setOption(...) on a closed Channel fails.
normanmaurer
force-pushed
the
options_closed_channel
branch
from
d803367 to
7e9824c
Compare
Lukasa
approved these changes
Mar 20, 2018
|
Rebase and merge |
|
@swift-nio-bot test this please |
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: Sometimes folks will want to print things about the HTTP2StreamChannel, and we should give them the things we can safely get. We also may want a shorter log for NIOHTTP2Handler as the standard description, with the wall of text available in the debug description. Modifications: - Conform HTTP2StreamChannel to CustomStringConvertible - Conform NIOHTTP2Handler to CustomDebugStringConvertible. Result: Even better debug info.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… called on a closed Channel
Motivation:
We should return a failed EventLoopFuture when getOption(...) / setOption(...) is called on a closed Channel as otherwise it may not be safe to modify the Channel ioptions after its closed.
Modifications:
Result:
Calling getOption(...) / setOption(...) on a closed Channel fails.